Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fusion] Renamed SyntaxException to FieldSelectionMapSyntaxException #7947

Merged
merged 2 commits into from
Jan 23, 2025

Conversation

glen-84
Copy link
Collaborator

@glen-84 glen-84 commented Jan 23, 2025

Summary of the changes (Less than 80 chars)

  • [Fusion] Renamed SyntaxException to FieldSelectionMapSyntaxException.

This was conflicting with HotChocolate.Language.SyntaxException.

Copy link

codecov bot commented Jan 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.32%. Comparing base (e4c6b7a) to head (3b7c903).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7947      +/-   ##
==========================================
- Coverage   74.32%   74.32%   -0.01%     
==========================================
  Files        2882     2882              
  Lines      150702   150702              
  Branches    17533    17533              
==========================================
- Hits       112005   112004       -1     
- Misses      32872    32873       +1     
  Partials     5825     5825              
Flag Coverage Δ
unittests 74.32% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@michaelstaib michaelstaib merged commit 01b22c4 into main Jan 23, 2025
5 checks passed
@michaelstaib michaelstaib deleted the gai/rename-syntax-exception branch January 23, 2025 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants